Repository navigation
chore: Improve Aviator FPR parsing and SSC preflight checks - #1138
Open
kireetivar wants to merge 22 commits into
Open
kireetivar wants to merge 22 commits into
kireetivar wants to merge 22 commits into
Conversation
…urce fragments per node
…er-node details to TRACE
… for every vulnerability
…oid retaining raw parse results
…nd missing TraceRefs
Entry parsing stopped after </URL>, so Fields were never read, and Field name/value were read from child elements instead of schema attributes. Fields now match the DOM path (AuxiliaryProcessor), so request values from external entries are set again.
Stop default preflight after the first eligible issue. Use validated SSC selector counts for quota checks with pagination fallback, exclude suppressed issues explicitly, and prevent test-only quota checks from starting an audit when counts are unknown.
Verify suppression exclusion with an uncached positive control in the current AV scope before using SSC counts. Fall back to pagination when compatibility is inconclusive. Reject invalid or unstable counts and let commands announce audit and quota decisions. Validation: 239 Aviator tests and formatting checks pass, including both suppression issue orders, unsupported probes, malformed counts, long boundaries, pagination inconsistencies, and quota progress messages.
kireetivar
marked this pull request as draft
October 15, 2026 05:13
Adapt formatted console status messages to the progress writer capabilities so line breaks in project names or server messages cannot abort an audit. Preserve multiline console support and the original log message. Validation: both Aviator module checks pass, including nine new regression tests covering the real single-line writer, line-break variants, formatted messages, and multiline writers.
Revert b567212 as requested. Restore the original Aviator progress rendering and remove the associated regression test file. The SSC preflight changes remain intact.
kireetivar
marked this pull request as ready for review
October 15, 2026 12:56
kireetivar
requested review from
anishkumarnagaraj-design,
ankit2995,
rsenden and
umadevis1
October 15, 2026 12:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces repeated work and memory use during FPR parsing. It also reduces SSC requests before a SAST audit.
Target branch:
dev/v3.x.Changes
FPR parsing
Parser corrections
SSC checks before download
--skip-if-exceeding-quotaand--test-exceeding-quota.QUOTA_UNKNOWN. They do not start an audit with an unverified count.Performance
These changes remove repeated template parsing, object construction, source extraction, and XML logging.
For an ordinary audit, a candidate on the first page allows the presence check to finish after one issue-page request. Exact quota checks can use smaller count responses when the compatibility checks succeed. Pagination remains necessary when those checks fail.
A speed increase for the complete parse or audit has not been measured in a controlled comparison. Peak-heap savings for the full branch have not been measured. The parser still keeps the final vulnerability list.
Tests
Passed on commit
26ba394441:Command:
The tests cover description output and cache limits, trace references, external entries, early exit, pagination, quota modes, and malformed SSC responses. Suppression tests cover both issue orders in normal and force modes.
This validation does not include a live SSC compatibility run or a native-image build.
Squash commit message