Repository navigation
Feat/v3.x/aviator/remove legacy fvdl parsing - #1137
Open
anishkumarnagaraj-design wants to merge 3 commits into
Open
anishkumarnagaraj-design wants to merge 3 commits into
anishkumarnagaraj-design wants to merge 3 commits into
Conversation
Remove FVDLProcessor, WebInspectParser and their legacy-only helpers, the unused fpr.jaxb generated model classes, and the unused TraceEntry/JAXB helper code. StreamingFVDLProcessor and StreamingWebInspectParser are the only parsers in use. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JAXB was only used by the removed legacy FVDL parser. Drop the jakarta.xml.bind, jaxb-runtime and jakarta.activation dependencies, the inert JAXB annotations on AuditResult, and the JAXB-specific native-image reflect/resource/proxy configs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anishkumarnagaraj-design
changed the base branch from
dev/v3.x
to
feat/v3.x/aviator/27.1
October 14, 2026 09:31
Contributor
Author
anishkumarnagaraj-design
requested review from
ankit2995,
kireetivar,
rsenden and
umadevis1
October 14, 2026 09:55
AuditFPR and the correlate-sast-dast parser each wired AuditProcessor, StreamingFVDLProcessor and FPRProcessor separately. Introduce SastFprParser as the single entry point and use it from both, and drop stale references to the removed DOM parser. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anishkumarnagaraj-design
force-pushed
the
feat/v3.x/aviator/remove-legacy-fvdl-parsing
branch
from
October 15, 2026 06:58
b4d21fd to
c4e164d
Compare
Contributor
Author
umadevis1
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This change removes legacy JAXB/DOM-based parsing code, eliminates JAXB dependencies that are no longer needed, and introduces a single entry point for SAST FPR parsing. There are no intended user-facing behavior changes.
Changes
1. Remove legacy DOM-based parsers (
aee369e524)FVDLProcessorandWebInspectParser.StreamingFVDLProcessorandStreamingWebInspectParserare now the only parsers in use.FVDLProcessor:ReplacementParserVulnerabilityMapperNodeProcessorTraceProcessorSnippetProcessorMetaInfoProcessorAuxiliaryProcessorfpr.jaxbclasses (~18,000 lines across 100 classes) and the unusedTraceEntry.DescriptionProcessor,XmlUtils, andEntry.StreamingWebInspectParserTestto validate XXE protection against the streaming parser only.2. Remove unused JAXB dependencies and native-image config (
d43eaefbc0)fcli-aviator-common:jakarta.xml.bind-apijaxb-runtimejakarta.activationAuditResult, which is not marshalled through JAXB.jaxb/reflect-config.jsonjaxb/resource-config.jsongrpc/proxy-config.json3. Unify SAST FPR parsing (
b4d21fd90e)SastFprParser.parse(fprHandle, sourceDecoder), which executes the shared parsing sequence:AuditProcessorStreamingFVDLProcessorFPRProcessorParsedFprDataAuditFPRandAviatorSSCCorrelateFprParserto use the new shared parser instead of wiring processors individually.AviatorSSCCorrelateFprParser.SastFprParserTestto verify that the facade returns the same results as the previous manual processor wiring.Acceptance Criteria
AuditFPRand the correlate command now shareSastFprParser.StreamingFVDLProcessorTest,FPRProcessorTest,StreamingWebInspectParserTest, and others) continue to pass unchanged.SastFprParserTestverifies parity with the previous implementation. Real-world FPR output comparison has not been performed.Out of Scope
RemediationProcessorcontinues to useStreamingFVDLProcessordirectly because it loads build metadata rather than full vulnerability data.audit.xmlDOM processing is unchanged because it requires reading and modifying XML rather than parsing FVDL content.Testing
Automated Tests
:fcli-core:fcli-aviator-common:test:fcli-core:fcli-aviator:test:fcli-core:fcli-app:testAll pass locally.
Additional Verification
fcli-appruntime classpath contains no JAXB orjakarta.activationdependencies.native-image-*CI jobs will validate compatibility. The removed configuration files referenced JAXB classes that no longer exist.