Repository navigation
feat(aviator): 2287147/2453546 accept application name or id in aviator app commands and help having examples - #1134
Open
anishkumarnagaraj-design wants to merge 2 commits into
Conversation
Numeric values remain interpreted as application id (backward compatible); non-numeric values are now interpreted as application name. The --app option of aviator ssc audit/correlate commands is unchanged (always a name). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anishkumarnagaraj-design
requested review from
ankit2995,
kireetivar and
rsenden
October 14, 2026 05:28
Contributor
Author
Contributor
Author
… help Add an Examples section and a required-option sentence to the help of all non-deprecated Aviator commands, including the app commands that accept an application name or id. AviatorHelpExamplesTest (fcli-app) parses every example against the real command tree, enforces the 80-column help width and checks that required options are documented. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
umadevis1
approved these changes
Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR contains two independent changes, one per commit, for the Aviator commands.
1. Admin app commands accept application name or ID 2287147
fcli aviator app get|update|delete|add-entitlement now accept either an application name or an ID.
Why this approach
Backward compatibility comes first, so lookup for existing inputs does not change. Making the commands consistent with the rest of fcli would require a notation or option change, for example id: / name: prefixes, which is better addressed in fcli v4.x. The considerations are documented in the decision record, which I will attach to the ticket.
2. Usage examples and required-option info in command help 2453546
Aviator command help now shows a description, syntax, required and optional parameters, and examples.
Added an Examples: section and a "Required option(s): ..." sentence to the help of all non-deprecated, runnable Aviator commands:
Examples follow the existing apply-remediations format, stay within 80 columns, and break long commands with an indented continuation line.
The deprecated entitlement list and ssc audit commands are left unchanged.
Tests
AviatorAppHelperTest and AviatorAppResolverMixinTest cover:
AviatorHelpExamplesTest (fcli-app) checks every non-deprecated Aviator command. It verifies that:
:fcli-core:fcli-aviator:test and :fcli-core:fcli-app:test pass.
Notes
Follow-up for fcli v4.x: