Skip to content

fix(tsjs): index string-named higher-order callbacks - #12

Merged
heiyan-2020 merged 1 commit into
mainfrom
fix/named-hof-functions
Sep 4, 2026
Merged

heiyan-2020 merged 1 commit into
mainfrom
fix/named-hof-functions

Conversation

@heiyan-2020

Copy link
Copy Markdown

Summary

  • index anonymous TypeScript/JavaScript callbacks passed to string-named fn/fnUntraced wrappers (including generator callbacks)
  • preserve the wrapper's logical name and qualified name in both tree-sitter and native Rust extraction
  • add TS/JS extraction and native-kernel parity coverage

Motivation

FM-Agent's OpenCode src/session scope contains 87 Effect.fn* callbacks. The previous CodeGraph release omitted these anonymous implementations, so the downstream spec graph saw only 129 entries (including fallback pseudo-functions) instead of the 185 real function nodes.

Validation

  • npm run build
  • npx vitest run __tests__/extraction.test.ts -t 'string-named HOF|unnamed HOF callbacks|fnUntraced'
  • CODEGRAPH_KERNEL_EXPECT=1 npx vitest run __tests__/kernel-*.test.ts (16 files, 156 tests)
  • OpenCode src/session: 87/87 named wrappers resolve to indexed functions

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T17:48:22.705998Z b7fc8fb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@heiyan-2020
heiyan-2020 merged commit 01ec00b into main Sep 4, 2026
1 check passed
@heiyan-2020
heiyan-2020 deleted the fix/named-hof-functions branch September 4, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant