test(cas): preserve independent Echo identity evidence

[flyingrobots]

Merged into main as 6626d265 after current-head independent review and hosted gates.

Summary

Preserve #723's useful independent Echo identity evidence after the actual Keep bridge superseded its mock witness. The CAS golden test checks the empty/text/256-byte-ramp raw hashes against retained fixed outputs; the canonical boundary link now names the invariant README present at its unchanged pinned Keep commit.

Scope

• Tests only, plus one canonical documentation link correction
• Runtime code

Links

Closes #780. Salvages #723 after actual bridge #768 and adapter #770 landed. The original proposal closes only after this replacement integrates. The agreed merge sequence places this PR after repaired #728; this ordering is not a correctness dependency.

Validation

• Guarded Docker: all 37 CAS tests pass, including the three-vector witness; all-target strict CAS Clippy and formatting pass.
• Kept fixture bytes and expected Echo digests from Bind Echo and Keep content identities explicitly #723 at db3e5dfe. Original provenance reports b3sum 1.8.5; no new external generator run or Keep execution is claimed by this new test.
• Inspected the actual local pinned Keep Git objects: the corrected invariant README exists, and the old architecture path does not.
• Final committed tree 72aa9747 matches the measured source candidate. Test log labels base 017a60f1 with these working-tree files; it is not relabeled as a clean-commit execution.

Documentation accuracy

Only the canonical link path changes; its commit pin and experimental adoption/authority posture remain intact. Actual Keep reconstruction evidence remains in the independent experimental workspace. There is no storage/hash/format/API change, so no changelog entry is required. README/GUIDE boundaries are unchanged.

Checklist

• Current-head hosted CI green
• One coherent independent identity-evidence outcome
• Current-head independent review approved

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: flyingrobots/echo/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: d5a6fbf7-3209-402e-9be1-87ff8b890cc8

📥 Commits

Reviewing files that changed from the base of the PR and between a53dc87 and 63135b6.

📒 Files selected for processing (2)

• crates/echo-cas/tests/identity_golden.rs
• docs/architecture/echo-keep-physical-content-boundary.md

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[flyingrobots]

Independent adversarial review: PR #781

Exact head 63135b6aa33301c73103ec2fd29ae99f4bd7914c, main base a53dc87f7b42a7c86eafc71f60ae12d0fa3113a0. Clean checkout and live GitHub coordinates confirmed. Full two-file diff inspected. No verified defect found.

Mandatory Verification Checklist

• Entire change: new27-line crates/echo-cas/tests/identity_golden.rs and one canonical reference URL correction. No shipped hashing,storage,format,API or backend change. No changelog addition required for this preserved test evidence/link correction.
• Actual production law echo-cas/src/lib.rs:82–85 hashes exact payload with raw BLAKE3 and wraps the32-byte result. BlobHash::Display at:66–75 formats every byte as two lowercase hexadecimal digits; fixed hex comparisons therefore check exact hash identity and existing display encoding. No length prefix,Keep identity cast or mock Keep hashing is introduced.
• Allthree fixtures/digests match original retained db3e5dfe4907d959c78859187f8f0a14612dd2ff:crates/echo-cas/tests/keep_identity_bridge.rs: empty; exact newline-terminated Keep exact bytes.\n;256-byte ascending ramp0..255. They are fixed independent expected values, not derived by the implementation under test. Original provenance states b3sum1.8.5; neither test nor review claims a new external generator run. Keep vectors/mock preimage implementation are intentionally omitted because actual experimental reconstruction already owns that evidence.
• Corrected link preserves Keep commit 3bf7b9179db41e90620e6d1875c2d40222a2330b. Independently inspected actual pinned Git tree/blob: docs/invariants/authenticated-reconstruction/README.md exists (blob79910b0821a574af63c725e240841f7f391979e5), old docs/architecture/authenticated-reconstruction-contract.md is absent. Opened README establishes authenticated reconstruction contract and non-durable ReferenceStore posture. This matches the canonical experimental boundary; no production adoption or durability conclusion follows.
• Merge 63135b6a parents72aa97478a4be29b154bb613ccfe06b61831e3eb anda53dc87f7b42a7c86eafc71f60ae12d0fa3113a0. No conflict. Incoming main is previously reviewed eight-file Continue retained native operation strands across host recovery #728 integration; CAS production,test,Cargo inputs and corrected boundary doc do not change across merge. Main-relative diff stays two files. Strand/WAL changes neither reinterpret Echo identities nor add a new CAS dependency.
• Source binding: measured identity manifest labels base017a60f1 with own test/doc changes, not clean finalhead execution. Independently hashed all15 relevant CAS files plus listed Cargo root/lock and boundary doc against final631 tree: zero mismatches. Broad merged tree includes newer strand code, so this review does NOT claim all manifest source files match final tree. Relevant measured CAS inputs are unchanged across the merge.
• landing-identity-green.log inspected:17unit+4boundary+1identity+5CAS+10physical-content tests =37passing tests. Empty doctest suite is zero, not another passing test. All-target strict CAS Clippy and formatting finish with guarded result exit0. No additional tests executed by reviewer.
• Resource receipt inspected:build14,195,337,010bytes<20GiB,data4,156,098,354<4GiB,logs24,167,605<128MiB;host/VM free bytes exceed50GiB. Parent guarded workload only; reviewer does not use workers or services.
• Fully paginated live connections for781:zero threads,zero reviews,two comments,no next pages. Comments are review quota/rate-limit notices,not approvals or findings. Original723:zero threads,zero reviews,one paginated automated conversation, no next page. Originalbody explicitly limits its old same-source test; preservation of useful raw Echo vectors/link is complete without pretending to execute Keep. Old723 should close superseded only after781integration.
• PRbody numeric/provenance claims match these sources:three vectors,256ramp bytes,37CAS tests,explicit old source/binary-generator provenance. Canonical boundary still records experimental disabled-by-default adapter,private identities and no restart durability. README/GUIDE authority boundaries remain unchanged.
• Live hosted CI remains separate:24success,fourskipped,eleveninprogress at inspection. Do not infer completion from independent approval; required checks, exact head,fresh discussions and protections must be rechecked before merge. Skipped jobs are not falsely counted as executed tests.

Ran: read-only source/Git/hash/API inspection. Read: fixed original vectors,pinned Keep contract,source manifest and guarded logs/receipt. Inferred: safe integration from exact relevant input equality. No tests,Docker,Keep execution or generator run by reviewer; no physical durability or new throughput evidence claimed.

Exact-head verdict: APPROVE 63135b6aa33301c73103ec2fd29ae99f4bd7914c. Current hosted/final live merge gates pending.

APPROVE

[flyingrobots]

Code Lawyer closeout: #781 integrated as 6626d265841a5a51b2e1473155f9f131b3d59778, closing #780.

• 72aa9747 preserves the three raw Echo vectors from Bind Echo and Keep content identities explicitly #723 and corrects the pinned canonical Keep path. No Keep algorithm mock or runtime change is added.
• 63135b6a integrates repaired Continue retained native operation strands across host recovery #728 without conflicts; relevant CAS inputs/test bytes remain identical to the guarded source candidate.
• 37 CAS tests, all-target strict Clippy and formatting passed. Zero doctests are not counted as executed cases. The pinned Keep Git blob independently confirms the corrected document path.
• Complete exact-head independent approval is posted above. Fresh merge gate confirmed head, no unresolved threads and green applicable hosted checks. Original Bind Echo and Keep content identities explicitly #723 is closing as superseded after this integration; original branch/history remains preserved.