Set Ready on OCI HelmRepository objects - #2151
Open
roshpr wants to merge 2 commits into
Open
Conversation
OCI HelmRepositories finished migration with an empty status, so kubectl Ready/Status columns stayed blank. Set Ready=True with reason NoIndex after migrating to a static object, and treat that state as fully migrated so a later reconcile does not wipe it. Assisted-by: Cursor Grok 4.6/cursor-grok-4.6-high-fast Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Rosh Ramadass <roshpr@gmail.com>
Karthik-Chowdary
left a comment
Karthik-Chowdary
left a comment
There was a problem hiding this comment.
I reviewed the migration predicate and condition invariants. The current static-object test can accept pre-migration or stale Ready conditions and skip the migration that establishes NoIndex; I left details inline.
roshpr
marked this pull request as ready for review
September 14, 2026 00:34
Stale Ready=True with reason Succeeded (or empty) was treated as a completed OCI migration, so the one-shot reconcile that sets NoIndex could be skipped. Require Ready=True with reason NoIndex before skipping migration, and assert that in predicate and reconciler tests. Assisted-by: Cursor Grok 4.6/cursor-grok-4.6-high-fast Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Rosh Ramadass <roshpr@gmail.com>
Author
|
@Karthik-Chowdary Thanks for the review. Hardened the static-object path so tests no longer accept pre-migration or stale Ready ( Pushed in 4368179. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2135
Developed with Cursor assistance.
OCI
HelmRepositoryobjects currently finish migration with an empty status, so the Ready/Status printer columns stay blank. After migrating to a static object, setReady=Truewith reasonNoIndex(no index Artifact; charts are resolved on demand). Treat that Ready state as fully migrated so a later reconcile does not wipe it.Empty status is no longer treated as already migrated, so existing
status: {}objects get the condition on controller restart.Test coverage
type: ociHelmRepository reports Ready without an index artifactDocumentation
Update
docs/spec/v1/helmrepositories.mdso OCI examples and status docs describe the Ready condition instead of a blank status.