Repository navigation
processor_sql: preserve resource and scope groups when filtering logs - #12506
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
force-pushed
the
fix/sql-group-markers
branch
from
October 26, 2026 19:23
5717884 to
1a2990f
Compare
edsiper
marked this pull request as ready for review
October 26, 2026 21:37
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL currently evaluates resource/scope transport markers as log rows. A
WHEREclause can delete those markers and strip metadata from surviving OTLP logs; projection can also alter the envelopes. This remains reproducible after the FTS merge.Skip non-normal log events before applying SQL row processing. Existing group normalization removes envelopes whose logs were all dropped.
For two resource groups containing IDs 1–4,
SELECT * FROM STREAM WHERE id = 1;retains ID 1 with its original resource/scope metadata, removes the now-empty second group, and reports one logical output record. The fix is independent of processor fusion in #12505.Rebased onto master
05048e35d. Validation:flb-it-processor_sqlpasses; full rebased PR range passes prefix lint.From the repository root, with
FLUENT_BIT_BINARYpointing at this branch's build:python -m pytest tests/integration/scenarios/processor_sql -q VALGRIND=1 VALGRIND_STRICT=1 python -m pytest tests/integration/scenarios/processor_sql -q ctest --test-dir build -R '^flb-it-processor_sql$' --output-on-failureNo public configuration, packaging or bundled-library changes. Target: master.