Repository navigation
Conversation
stmh
force-pushed
the
feat/app-navbar-end
branch
from
October 23, 2026 19:31
89bbfc7 to
aaab760
Compare
postcss-html 2.0.0 (via the stylelint toolchain) requires Node ^22.12 or >=24, so pnpm install fails with ERR_PNPM_UNSUPPORTED_ENGINE on Node 20 and every lint, bundle and storybook job is red, on main and on every PR. The Dockerfiles already build on node:22. The package's engines field stays >=20: the requirement is a dev-toolchain one. Claude-Session: https://claude.ai/code/session_01XR2k7eeSeAKTuptqh4uyee
stmh
force-pushed
the
feat/app-navbar-end
branch
from
October 23, 2026 21:23
aaab760 to
658394c
Compare
…schemas - Storybook: ubuntu-latest is now 26.04, where Playwright cannot install Chromium. Pin ubuntu-24.04. - oasdiff's install script now installs to /usr/local/bin itself; the following mv found nothing and failed the job. - OpenAPI lint: nullable needs a sibling type (struct rule). The two allOf + nullable properties on PlaygroundChatBinding and WorkflowPlayground gain type: object. Claude-Session: https://claude.ai/code/session_01XR2k7eeSeAKTuptqh4uyee
stmh
force-pushed
the
feat/app-navbar-end
branch
from
October 23, 2026 21:29
658394c to
f0e3265
Compare
d34dman
added a commit
that referenced
this pull request
Oct 23, 2026
# Conflicts: # libs/flowdrop/CHANGELOG.md
Collaborator
|
Released in @flowdrop/flowdrop 2.16.0 (tag What shipped
Different from the PR: navbarEnd?: (target: HTMLElement) => void | (() => void)// Svelte host
navbarEnd: (target) => {
const c = mount(UserMenu, { target });
return () => unmount(c);
}
// Plain JS host
navbarEnd: (target) => target.append(button)
For flowdrop-rs: the editor route mounts through Tests: the e2e from the PR ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Apptakes a new optionalnavbarEnd?: Snippetprop and forwards it toNavbar's existingendslot, which renders before the settings gear. It shows only when the navbar does.mountFlowDropApptakes the same option and passes it on, so a host that mounts through the function (and keeps its draft manager and host colour scheme) can use it too.Why
A host that embeds the full
App(flowdrop-rs's editor route) needs to put its own controls in the editor navbar, such as the user menu, so the editor and the host's admin UI share one toolbar instead of stacking two.Navbaralready supports this;Appjust didn't pass it through.Tests
tests/e2e/editor-branding.spec.tsgains "Navbar end content". The/test/editor?navbarEnd=1route passes a snippet, and the test asserts that it renders inside.flowdrop-navbar__end, and that nothing renders without it.tests/unit/mount/navbarEnd.test.tschecks thatmountFlowDropAppforwards the snippet.svelte-check: 0 errors, 0 warnings. Prettier is clean.CHANGELOG: Unreleased / Added.
https://claude.ai/code/session_01XR2k7eeSeAKTuptqh4uyee