feat: resource view registries for storefront tables and panels - #110
Merged
Merged
Conversation
Extensions can add columns, row actions, bulk actions and toolbar buttons through storefront:table:<resource>:<slot>, and buttons and menu items to the order and customer panels through storefront:details:<resource>:<slot>. - orders moves to Layout::Resource::Tabular with actionButtons/bulkActions - customers and the order/customer panels (and the order context panel) take their registry - promotions and network views keep their layouts (custom empty states, category picker) and merge registered columns and toolbar buttons through BaseController helpers - stable ids on built-in items, query params include registered filters Requires @fleetbase/ember-core 0.3.25 and @fleetbase/ember-ui 0.4.5.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2282 2282
===========================================
Files 182 182
Lines 9082 9082
===========================================
Hits 9082 9082
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions can add columns, row actions, bulk actions and toolbar buttons to storefront tables through
storefront:table:<resource>:<slot>. They can add buttons and menu items to the order and customer panels throughstorefront:details:<resource>:<slot>.Changes
Layout::Resource::Tabular, withactionButtonsandbulkActionsgetters for cancel, delete and dispatch. The Export button still has no click handler, as before.storefront-order-actions).BaseControllerhelpers.ids on built-in items; index query params include registered filter params; registries declared inextension.js.Depends on
Merge only after both are published. Before merging, bump
@fleetbase/ember-coreto^0.3.25and@fleetbase/ember-uito^0.4.5, and refresh the lockfile. Until then this branch builds against the old APIs and will not run.Naming and API reference:
docs/resource-view-registries.mdin ember-core.Testing
Lint and template-lint pass. No tests were run locally.