release/v0.4.23 - #109
Merged
Merged
release/v0.4.23#109
Conversation
The storefront throttle ran before the session was set, so its key fell back to route domain + client IP: behind a proxy every store shared one bucket, and the key was identical to core-api's limiter. Key it on the store key plus the client IP instead.
fix(throttle): isolate the storefront rate limiter per store and device
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 2281 2282 +1
===========================================
Files 182 182
Lines 9080 9082 +2
===========================================
+ Hits 9080 9082 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.4.23: the Storefront API rate limiter is isolated per store and device. The notes are in
RELEASE.md.Includes:
Merge #108 into this branch first. Merging this branch into
maintagsv0.4.23. After tagging, bumpfleetbase/storefront-apiinapion fleetbase/fleetbaserelease/v0.7.66.