feat: resource view registries for ledger tables and panels - #28
Merged
Merged
Conversation
Extensions can add columns, row actions, bulk actions and toolbar buttons to ledger tables, and buttons and menu items to its details panels, through ledger:table:<resource>:<slot> and ledger:details:<resource>:<slot>. - @registry on every Tabular index view and Panel details view - Gateway::Hub merges registered columns once in the controller, and passes the registry to its TabularActions header - stable ids on built-in columns, actions and buttons so registered items can anchor with before/after - index query params include registered filter params - registries declared in extension.js Requires @fleetbase/ember-core 0.3.25 and @fleetbase/ember-ui 0.4.5.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1253 1253
===========================================
Files 74 74
Lines 6990 6990
===========================================
Hits 6990 6990
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions can add columns, row actions, bulk actions and toolbar buttons to ledger tables through
ledger:table:<resource>:<slot>. They can add header buttons and "…" menu items to ledger's details panels throughledger:details:<resource>:<slot>.Resources:
account,gateway,invoice,invoice-template,journal,transaction,wallet.Changes
@registryon everyLayout::Resource::Tabularindex view and everyLayout::Resource::Paneldetails view.Gateway::Hubrenders its own column picker, so the gateways controller merges registered columns once viagatewayActions.mergeRegisteredColumns. The registry goes to the hub'sTabularActionsfor buttons and bulk actions.ids on built-in columns, actions and buttons (a column's dasherizedvaluePath, an action's handler name), so registered items can anchor withbefore/after.queryParamsgo through<x>Actions.queryParamsFor(), so registered filter columns work.extension.js.Depends on
Merge only after both are published. Before merging, bump
@fleetbase/ember-coreto^0.3.25and@fleetbase/ember-uito^0.4.5, and refresh the lockfile. Until then this branch builds against the old APIs and will not run.Naming and API reference:
docs/resource-view-registries.mdin ember-core.Testing
Lint and template-lint pass. No tests were run locally.