feat: resource view registries for IAM tables - #39
Merged
Merged
Conversation
Extensions can add columns, row actions, bulk actions and toolbar buttons through iam:table:<resource>:<slot>, and buttons and menu items to the edit dialogs through iam:details:<resource>:<slot>. - groups, roles and policies move to Layout::Resource::Tabular with actionButtons/bulkActions getters (roles and policies keep their reload) - users keeps its TabularActions header; its columns merge in the controller - edit dialogs pass registered details buttons as footer actionButtons - stable ids on built-in items, query params include registered filters - fix the delete-group accept button reading the misspelt aim.* key Requires @fleetbase/ember-core 0.3.25 and @fleetbase/ember-ui 0.4.5.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions can add columns, row actions, bulk actions and toolbar buttons to IAM tables through
iam:table:<resource>:<slot>. They can add buttons and menu items to the edit dialogs throughiam:details:<resource>:<slot>.Resources:
user,group,role,policy.Changes
Layout::Resource::Tabular, withactionButtonsandbulkActionsgetters. Roles and policies keep their reload button via@onReload, and search still respectsiam list ….TabularActionsheader with@registry. Its columns merge in the controller (userActions.mergeRegisteredColumns), because the table renders separately from the header.actionButtons.ids on built-in items; index query params include registered filter params; registries declared inextension.js.aim.groups.index.delete-group.Depends on
Merge only after both are published. Before merging, bump
@fleetbase/ember-coreto^0.3.25and@fleetbase/ember-uito^0.4.5, and refresh the lockfile. Until then this branch builds against the old APIs and will not run.Naming and API reference:
docs/resource-view-registries.mdin ember-core.Testing
Lint and template-lint pass. No tests were run locally. The groups, roles and policies pages now show the standard filter and column pickers, so give them a click-through.