Skip to content

Fix new order form resetting fields when editing a place modal (#651) - #349

Open
osmanhasnoon wants to merge 1 commit into
fleetbase:mainfrom
osmanhasnoon:fix-order-form-place-reset
Open

osmanhasnoon wants to merge 1 commit into
fleetbase:mainfrom
osmanhasnoon:fix-order-form-place-reset

Conversation

@osmanhasnoon

Copy link
Copy Markdown

Implemented the fix outlined in #651 to resolve draft order field being wiped when saving an updated address in the place edit modal.

  • Guarded willTransition in OperationsOrdersIndexRoute so controller.reset() only executes when actually leaving the route.
  • Updated editPlace in OrderFormRouteComponent to pass { refresh: false } and safely synchronize waypoint updated locally.

Big thanks to @spanchenko for outlining the root cause and recommended fix in #651

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5f846a9) to head (5ae1920).

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #349   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity     12329     12329           
===========================================
  Files            600       600           
  Lines          46419     46419           
===========================================
  Hits           46419     46419           
Flag Coverage Δ
backend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant