fix(menu): carry permission onto registered header shortcuts - #94
Merged
Merged
Conversation
registerHeaderMenuItem rebuilt each shortcut field by field and dropped permission, so the header could not filter shortcuts by permission. Shortcuts now keep their own permission or inherit the parent item's.
This was referenced Sep 27, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerHeaderMenuItemrebuilds each shortcut field by field and droppedpermission, so the header could never filter shortcuts by permission. Shortcuts now keep their ownpermission, or inherit the parent menu item's.The header filtering itself is in fleetbase/ember-ui (
SmartNavMenu). Fleet-Ops shortcuts now declare their module permission (fleetbase/fleetops).Test plan
fleet-ops list vehicleno longer sees the Vehicles shortcut in the header