feat: add a hand-written Prometheus label values method - #77
Merged
Merged
Conversation
The generator skips this operation because it has a path parameter, so it never gets a typed client method. Add one by hand: GET the label's values through the Monitors proxy with the X-DSID header, and decode straight into the generated PrometheusLabelValuesResponse rather than through the Flashduty envelope, since the endpoint returns the data source's native Prometheus payload unwrapped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /monit/prometheus/api/v1/label/{label_name}/valueshas a path parameter, so the generator skips it and it never got a typed method. This addsDataSourcesService.ReadPrometheusLabelValues(ctx, dataSourceID, labelName)by hand.X-DSIDheader and path-escapes the label name.{request_id, error, data}envelope. A 2xx body is decoded straight into the generatedPrometheusLabelValuesResponse.Messageinstead of being parsed as a Flashduty error.Tests
data_sources_prometheus_test.gocovers path escaping, the header and app key, decoding, and the non-enveloped error path.go build ./...,go vet ./...andgo test -race ./...pass.