Repository navigation
docs(realtime-stt): drop the client-set draft interval #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+4
−16
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 Supported by static analysis
Script executed:
Repository: fishaudio/docs
Length of output: 41434
Document the
draft_interval_mscompatibility exception.Removing
draft_interval_msfromAsrResultsandAsrResultsUpdateleaves the field undocumented. The endpoint reference treats any unknown field asinvalid_config, which closes the connection with 4400 (api-reference/endpoint/websocket/asr-realtime.mdx, line 123). Itsconfigurerule rejects unknown fields as well (line 202). A client that still sendsresults.draft_interval_mstherefore matches the documented rejection rule. The PR states that the server accepts and ignores this field for existing clients. The schema and endpoint docs need to state that exception, or they describe behavior that conflicts with the stated compatibility.Add the exception at the object level in both schemas, and name the same exception in the endpoint unknown-field rules for both
configandconfigure.Suggested schema note
AsrResults: type: object + description: | + `draft_interval_ms` is no longer defined. Existing clients may still send it; the server accepts and ignores it. properties: