Repository navigation
Entity save - Handle preSave callback error - #1015
Open
AleksandarCila wants to merge 2 commits into
Open
AleksandarCila wants to merge 2 commits into
AleksandarCila wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you edit an entity of a collection that have a defined preSave callback (both side controller or full screen editor), on save, if preSave callback throws an error, form will behave as that entity was saved. Save doesnt really happen, but form behaves as if it does, and it can be misleading for a user.
Presave_error.mov
I have added custom error wrapper that is used to track in which stage of saving process error occurred.
I have been investigating this issue: #713
I didnt quite understand, but it seems that both from direct table editing, or through form, error handling on presave callback is handled both visually and logically. Feel free to close the issue if you think this helps in solving it.