Repository navigation
chore: re-vendor bitn.lua from lua-bitn v0.6.5 - #18
Merged
Merged
Conversation
![svc-finitelabs[bot]](https://avatars.githubusercontent.com/in/3141848?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verified at 40f2ccf: vendor/bitn.lua is byte-identical to the lua-bitn v0.6.5 release asset (sha256 3c7f97e5...), and the main copy is byte-identical to the v0.6.4 asset, so the only change is the VERSION stamp on line 3571. v0.6.4...v0.6.5 is #24 and #25, touching only .github/workflows/, CLAUDE.md and README.md. CI green across all 12 jobs, including Lua 5.5 and the three lua-openssl versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor/bitn.luais now the lua-bitnv0.6.5release asset, copied verbatim. That asset is byte-identical to a localmake buildof the tag (sha2563c7f97e539617afc800926ee31186b0d53b3bd8b97292e65a694a96ee645fccd).bitn v0.6.5 is v0.6.4 plus two CI-only changes: finitelabs/lua-bitn#24 (runner pin) and finitelabs/lua-bitn#25 (action and tool pin bumps, Lua 5.5 added to the test matrix). Neither touches
src/, so the only diff here is the embeddedVERSIONstamp,v0.6.4→v0.6.5. Tests build against the vendored file, so CI exercises it.Verified locally:
make check,./run_tests.sh allon LuaJIT 2.1 and Lua 5.5.1 (16/16 each, including thelpackmodule), andmake build(core and portable).Not tagging on merge. The OpenSSL bignum work (branch
claude/openssl-big-number-support-2a0c40) is about to change this library. The next lua-crypto release waits for it, so lua-noiseprotocol only has to roll crypto out once.