ES-CL: the identifier was 0 in every row - #261
Merged
Merged
Conversation
This was referenced Sep 11, 2026
DN_OID is 0 in every row of every province, so the collection was published with 9,109,136 fields sharing one id. C_REFREC is SIGPAC's own 23-character recinto reference and identifies a field; 11 of the 13,022,051 recintos carry none and are dropped under the bounded rule. The ITACyL server is https-only now, and the 2025 download puts its shapefiles in province subfolders. The determination date comes from the variant year. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
ivorbosloper
force-pushed
the
split/es_cl
branch
from
September 12, 2026 12:50
3fa9e57 to
6287095
Compare
m-mohr
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the
publish-portolansplit (#231-#260). Castilla y León, with a convert test and fixture it did not have.DN_OIDis0in every row of every province, so the collection was published with 9,109,136 fields sharing one id.C_REFRECis SIGPAC's own 23-character recinto reference and identifies a field: unique across all 13,022,051 recintos except 11 that carry none, which are dropped under the bounded rule.Two more: the ITACyL server is https-only now, and the 2025 download puts its shapefiles in province subfolders. The determination date comes from the variant year.
Original commits: 047dd0b, 0fda9d4, and the es_cl halves of 7f33180 and f6e3ab5.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG