Repository navigation
build: standardize on Node 26 - #272
Merged
Merged
Conversation
Fresh CI runners cannot pull the original MinIO images. Use a pinned release of the maintained Silo fork for the S3 test fixture and local Compose service.
Pin the stable glibc image, create test buckets through S3, and initialize the Compose bucket after startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
The server and Docker images still targeted Node 25, while release automation selected the latest LTS independently. Use Node 26 throughout so development, CI, releases, and both image variants share the same major version. Replace the unavailable MinIO test image with a pinned RustFS release so fresh CI runners can start the S3 tests.
📦 Changes
package.json, matching CI.rustfs/rustfs:1.0.0-glibcfor the S3 test fixture and local Compose service, creating buckets through the S3 API.✅ Verification
pnpm run lint:ci: passed on Node 26.10.0.pnpm run type-check: passed on Node 26.10.0.pnpm run test:matrix: all nine combinations passed on Node 26.10.0 before the fixture change, using the locally cached MinIO image.VITEST_DB_DRIVER=sqlite VITEST_STORAGE_DRIVER=s3 pnpm run test:run: 45 passed, 2 backend-specific skips with RustFS 1.0.0-glibc.docker pull rustfs/rustfs:1.0.0-glibcanddocker compose config --quiet: passed.docker build --pull -t cache-server-node26:verify -: passed using a context containing the tracked working-tree files, including the production install and build.docker build --pull --build-arg BASE_IMAGE=platformatic/node-caged:26-alpine -t cache-server-node26-caged:verify -: passed with the same context.🔍 Reviews
ssh2cannot compile its optional crypto accelerator on Node 26. Its installer succeeds with the JavaScript fallback.