Repository navigation
browser_close can wait up to 2 minutes for a stuck download #284
Description
Activity
I’m taking this and will implement the bounded close wait, cancellation reporting, regression coverage, and documentation update.
It's yours, @abhinavrastogi2627, thanks! The details are in the issue. A real stuck download (a local server that sends headers and then stalls) is the easiest way to check the close returns within about 10 s. Mention #284 in the PR.
Follow-up to #202.
browser_close(sentient/browser/service.py, theclose_toolpath) waits for unfinished downloads for the full 120 s download limit while holding the browser lock. With a stuck download, a real test measured 118.9 s. Meanwhile the chat turn stalls, other browser tools are blocked, and a script callingbrowser_closeruns into the 120 s sandbox limit.Fix: wait a short time (5 to 10 s), then cancel what's left and report it in
download_errors. Add a sentence todocs/API.mdsayingbrowser_closewaits briefly for downloads, since it currently says actions never wait.Done when: closing with a stuck download returns within about 10 s and reports the cancelled download, with a test.