FIX: skip gated *-end nodes when the start is suppressed - #92
Open
BetterAndBetterII wants to merge 1 commit into
Open
FIX: skip gated *-end nodes when the start is suppressed#92BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Start directives return [] for hide_solutions or :hidden:, leaving unmatched *-end marker nodes in the doctree. Those nodes had no writer visitors, so HTML raised NotImplementedError. Skip them. Fixes executablebooks#89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start directives return
[]whenhide_solutionsis set or the start has:hidden:. The matchingsolution-end/exercise-endstill emits a marker node. Those nodes were registered with no writer visitors, so HTML (and LaTeX) raisedNotImplementedErroron the leftover.Register SkipNode visitors for
exercise_end_nodeandsolution_end_nodeso unmatched gated end markers are not written. Covers all three crash modes from the issue:hide_solutionswith{solution-start}/{solution-end}:hidden:on{solution-start}:hidden:on{exercise-start}Fixes #89