Conversation
ejsmith
marked this pull request as ready for review
October 3, 2026 19:57
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5143fea498
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ejsmith
force-pushed
the
feature/aspire-elasticsearch-9
branch
from
October 4, 2026 22:29
5143fea to
b9dc2e9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run Aspire development and its backend-test infrastructure on the published
exceptionless/elasticsearch:9.5.4image withmapper-size, and use matching Kibana 9.5.4. This enables local application validation before upgrading the deployed dev cluster.Use
exceptionless.data.v2so starting Aspire preserves the existing 8.x volume instead of upgrading its data directory in place. The volume version increments for breaking data changes. Existing local data is not migrated automatically. No application API, client-library, index-schema, Compose, or deployed-cluster configuration changes.Compatibility and release review
Verification
mapper-size9.5.4 using a fresh volume; Aspire reports Elasticsearch, Kibana, and the API healthy. Runtime checks preceded the final volume-name correction toexceptionless.data.v2; that correction was verified statically.test-api, all six browser shards andtest-e2e,test-client, and Docker build passed.Breaking changes
No public API changes. Local Aspire starts with fresh Elasticsearch data; the previous
exceptionless.data.v1volume remains available for 8.x.