Repository navigation
fix(verifier): match header blobs wrapped in DAHeaderEnvelope - #63
Merged
Merged
Conversation
ev-node publishes headers inside a DAHeaderEnvelope with an extra envelope signature that cannot be recomputed, so commitment-based lookup never matched. Compare by signed-header content instead, sharing the unwrap-and-compare loop with data blob verification. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ev-node publishes header blobs inside a
DAHeaderEnvelopethat carries an extra envelope signature, so the old commitment-basedVerifyBlobAtHeightnever matched them and headers were reported as missing. This replaces it withVerifyHeaderBlobAtHeight, which unwraps each published blob to its signed-header content (dropping the envelope signature) and compares it to the stored block; legacy blobs without an envelope still match. Header and data verification now share oneverifyBlobAtHeightloop. Adds a table test covering envelope, legacy, mismatched, empty and undecodable blobs, and updates the README to explain the matching and what "missing" means.