Repository navigation
fix(manager): stop stale page locks, alert loops and double alerts - #2543
Merged
Merged
Conversation
elcreator
commented
Nov 2, 2026
elcreator
commented
- A manager whose last page was System Settings (or another lockable page) kept it locked for everyone after closing the browser: the lock now needs a signed-in session (session_timeout, as the session cleanup uses).
- A new install's dashboard redirected to settings held by another manager; the locked page went back to the dashboard and the two looped.
- The alert page started its timer before load, so on a slow stylesheet the native alert() fired before the manager frame replaced it: two popups.
- A tab whose page alerted without an element id (settings, no privileges) was left blank and open; it is closed now.
- A manager whose last page was System Settings (or another lockable page) kept it locked for everyone after closing the browser: the lock now needs a signed-in session (session_timeout, as the session cleanup uses). - A new install's dashboard redirected to settings held by another manager; the locked page went back to the dashboard and the two looped. - The alert page started its timer before load, so on a slow stylesheet the native alert() fired before the manager frame replaced it: two popups. - A tab whose page alerted without an element id (settings, no privileges) was left blank and open; it is closed now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.