Skip to content

Stabilize HTTP API startup and request handling - #185

Merged
eviltester merged 1 commit into
masterfrom
codex/fix-apichallenges-docker-run
Sep 17, 2026
Merged

eviltester merged 1 commit into
masterfrom
codex/fix-apichallenges-docker-run

Conversation

@eviltester

Copy link
Copy Markdown
Owner

Summary

  • split Thingifier REST route configuration from Javalin startup so downstream apps can register hooks before the server starts
  • serialize generated HTTP API entrypoints per Thingifier model to avoid immediate read-after-write visibility races across Jetty worker threads

Verification

  • mvn -B -pl ercoremodel,thingifier -am install -DskipTests
  • mvn -B -pl thingifier test
  • full Maven verification from commit hook passed across all Thingifier modules

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-17T09:06:32.115086Z 15d8d44 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15d8d44e49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 298 to 299
httpServer = new JavalinHttpServer(proxyport, staticFilePath, routeRegistry);
httpServer.start();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Record the HTTP server only after startup succeeds

When JavalinHttpServer.start() throws, such as while the configured port is temporarily occupied, httpServer remains non-null. If the caller fixes the cause and retries startHttpServer(), the new guard returns without attempting to bind, leaving this MainImplementation permanently unable to start; assign the field only after a successful start or clear it on failure.

Useful? React with 👍 / 👎.

@eviltester
eviltester merged commit e3d00ff into master Sep 17, 2026
3 checks passed
@eviltester
eviltester deleted the codex/fix-apichallenges-docker-run branch September 17, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant