Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Date only parses when it is the last thing in the field value. Anything after it fails, so all of these throw
Parse error: Expected a digit (0-9), whitespace or EOL:parseDatereads digits until the end of the input and throws on any other character. RFC 9651 section 4.2.9 parses a Date by running "Parsing an Integer or Decimal" on the rest of the input, which stops at the first character that isn't part of the number, and then fails if the result is a Decimal.parseDatenow does the same withparseIntegerOrDecimal. That also brings back the 15-digit limit from 2.0.3, and a decimal such as@1659578233.5still fails.None of the HTTPWG tests put a Date anywhere but at the end of the field, which is why the suite didn't catch this. I added
test/parser-tests.jswith these cases in the same style asserializer-tests.js. The three parsing cases fail onmain. The HTTPWG tests still pass, andmake lintis clean.