Repository navigation
Replace jsonista with charred to drop jackson-core - #5
Merged
ericdallo merged 1 commit intoOct 6, 2026
Merged
Conversation
jsonista 0.3.13 pulls jackson-core 2.18.2, flagged by CVE-2026-89425 (GHSA-7hhh-6rmp-j9qf). charred is jackson-free and produces identical output for metrepl's metric payloads (keywords, strings, numbers, booleans, nested maps/vectors) with :escape-slash false to match jsonista's default of not escaping forward slashes. Adds format_test.clj covering :json, :edn, and :summary paths; the format namespace previously had no test coverage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Context
jsonista 0.3.13transitively pullsjackson-core 2.18.2, flagged by CVE-2026-89425 / GHSA-7hhh-6rmp-j9qf (unboundedStringBuilderinUTF8DataInputJsonParser, DoS). Every consumer of metrepl gets flagged by dependency scanners. metrepl's only jsonista use is onewrite-value-as-stringcall on simple metric maps.Solution
Swap jsonista for
charred, a jackson-free JSON lib. This removesjackson-corefrom metrepl's dependency graph entirely.write-json-strwith:escape-slash falseproduces byte-identical output to jsonista for these payloads (namespaced keywords, strings, numbers, booleans, nested maps/vectors).Adds
format_test.cljcovering:json,:edn,:summary(previously uncovered). Verified: the same tests pass against both jsonista and charred, confirming identical behavior.🤖 Generated with Claude Code