Conversation
|
There is no change log for this pull request yet. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Current CI configuration likely won’t run the React matrix on typical main/master merges and the Playwright reporter override prevents generating the playwright-report/ artifacts the workflow uploads.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This PR expands the library’s stated compatibility to React 16–19 and adds tooling/CI to validate that claim by running the Playwright suite against multiple React major versions.
Changes:
- Broadened
peerDependenciesto allow React / ReactDOM>=16.14.0 <20. - Added scripts to install a chosen React major version and run the compatibility test suite.
- Updated GitHub Actions workflow to run full-browser tests on PRs and a React-version matrix on pushes; documented local matrix commands in the README.
| File | Description |
|---|---|
scripts/test-react-version.cjs |
Installs a selected React major + typings, adds a legacy shim for react-dom/client on React 16/17, then runs test:compat. |
README.md |
Documents new local commands for testing across React 16–19 and running the full matrix. |
package.json |
Adds new test scripts (compat, all-browsers, per-react-major, matrix) and updates peer dependency ranges. |
.github/workflows/playwright.yml |
Splits CI into PR all-browsers testing and a push-time React-version matrix job, with report artifact uploads. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+55
to
+57
| push-react-matrix: | ||
| if: github.event_name == 'push' && needs.detect-push-pr-association.outputs.has_pr != 'true' | ||
| needs: detect-push-pr-association |
Comment on lines
+16
to
+18
| "test": "npm run test:compat", | ||
| "test:compat": "npm run build-example && npx playwright test --project=\"base tests\" --project=chromium --reporter=line", | ||
| "test:all-browsers": "npm run build-example && npx playwright test --reporter=line", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.