Repository navigation
Bring the 2.0.16.1 and 2.0.16.2 hotfix fixes to master - #308
Merged
Merged
Conversation
…ion to 1.16.1 Includes the ContractRef / ResponsibilitySet AssociatedContract change from entur/NeTEx#63. The 1.16 schema is still downloaded for validation. (cherry picked from commit a23f029)
(cherry picked from commit 1013129)
…tRef (NeTEx 1.16.1) (cherry picked from commit 2c67705)
2.0.16.1 generated the model from the 1.16.1 schema but kept validating NetexVersion.v1_16 against the original 1.16 schema, and added v1_16_1 for the new one. Documents only ever declare the minor version (1.16:NO-NeTEx-networktimetable:1.6), so every consumer maps them to v1_16, and a document the model itself produces is rejected: an AssociatedContract on a ResponsibilityRoleAssignment fails with cvc-complex-type.2.4.a. Getting the 1.16.1 schema meant declaring a 1.16.1 version that no client should have to write. 1.16.1 is purely additive over 1.16: stripped of annotations, the only differences are the optional AssociatedContract element and the ContractRef types it needs. Anything valid against 1.16 stays valid. - v1_16 now loads its schema from the 1.16.1 folder. toString still returns "1.16": consumers derive the declared version from it, and returning "1.16.1" would stop them accepting 1.16. - v1_16_1 is kept as a deprecated alias for the same schema, so code compiled against 2.0.16.1 keeps working. - LATEST is v1_16. - The 1.16 schema is no longer downloaded or shipped. (cherry picked from commit 815e140)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Brings the NeTEx 1.16.1 hotfix work from
hotfix/2.0.16.1andhotfix/2.0.16.2(#307) tomastermasterof entur/NeTExv1_16validates against the 1.16.1 schema,v1_16_1becomes a deprecated alias,LATESTisv1_16, and the old 1.16 schema is no longer shipped