Repository navigation
Remove the plexus-compiler-javac override from maven-compiler-plugin - #303
Merged
Merged
Conversation
The override pinned plexus-compiler-javac separately from the plexus-compiler-api/manager versions brought in by maven-compiler-plugin. Renovate bumped it to 2.17.1 while maven-compiler-plugin 3.16.0 still ships plexus-compiler-api 2.17.0, causing NoSuchMethodError on AbstractCompiler.joinAnnotationProcessors (added in api 2.17.1). Letting the plugin manage its own plexus-compiler version keeps the modules consistent.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Renovate PR #288 fails at compile time:
The pom pins
plexus-compiler-javacas a dependency ofmaven-compiler-plugin, apart from the other plexus-compiler modules. #288 bumps it to 2.17.1, whilemaven-compiler-plugin3.16.0 still brings inplexus-compiler-api/plexus-compiler-manager2.17.0.JavacCompiler2.17.1 callsAbstractCompiler.joinAnnotationProcessors, which only exists fromplexus-compiler-api2.17.1.Fix
Remove the override (added in 2017) so the plugin uses the plexus-compiler version it was built and tested with, and all modules stay on the same version.
Verification
mvn clean test-compilesucceeds:maven-compiler-plugin3.15.0-Dmaven-compiler-plugin.version=3.16.0(the version from Update all non-major dependencies (minor) #288)Once this is merged, Renovate should rebase #288 so that it only contains the plugin bump.