Repository navigation
Pin JUnit to 5.x on the Java 11 line - #302
Merged
Merged
Conversation
JUnit 6 requires Java 17, but master compiles for Java 11, so test compilation fails with 'class file has wrong version 61.0, should be 55.0'. Revert junit.version to 5.14.4 (reverts #250) and add a Renovate rule restricting org.junit to <6.0.0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI build on master fails since #250 bumped JUnit to 6.1.3:
JUnit 6 requires Java 17, while master compiles for Java 11 (
jdk.version=11).Changes:
pom.xml:junit.version6.1.3 → 5.14.4 (latest 5.x)renovate.json: restrictorg.junitto<6.0.0so Renovate does not propose JUnit 6 again on this linemvn clean installpasses locally (85 tests, 0 failures).Note: the
upgrade-netex-2.0branch targets Java 21 and can use JUnit 6, so this rule and version should be left out when merging master into it.