Repository navigation
NXT-10859: Adapted code for eslint 10 - #193
Merged
Merged
Conversation
ion-andrusciac-lgp
approved these changes
Oct 6, 2026
# Conflicts: # npm-shrinkwrap.json # package.json
# Conflicts: # CHANGELOG.md # npm-shrinkwrap.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Updated the repo's own lint setup to ESLint 10.
Resolution
Test app builds: WebdriverIO (9.31) always adds
--import <tsx loader>toprocess.env.NODE_OPTIONS, and theenact packprocesses spawned bybuild-apps.jsinherit it.The
tsxhook compiles required ES modules to CommonJS, so theimportstatements inside the ESM-only@eslint-react/eslint-plugin(loaded byeslint-config-enact) are resolved withrequireconditions and fail on packages with animport-onlyexportsmap.epack()now removes thetsxloader flag fromNODE_OPTIONSfor the spawnedenactprocess;Lint (dev only):
eslintto^10.11.0.react/forbid-foreign-prop-types: 'off'override. The rule has no replacement in the ESLint 10 config and is no longer enabled.screenshot/utils/confHelpers.js: the "Session health check failed" error now keeps the original error ascause(preserve-caught-error, new in ESLint 10's recommended rules).screenshot/utils/redist/newFiles.js: removed the/* eslint-env browser */comment, which flat config ignores and ESLint 10 reports as an error.documentandwindoware already defined as globals byeslint-config-enact.Additional Considerations
Links
NXT-10859
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)