Skip to content

NXT-10859: Adapted code for eslint 10 - #193

Merged
hong6316 merged 9 commits into
developfrom
feature/NXT-10859
Nov 2, 2026
Merged

hong6316 merged 9 commits into
developfrom
feature/NXT-10859

Conversation

@daniel-stoian-lgp

@daniel-stoian-lgp daniel-stoian-lgp commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Updated the repo's own lint setup to ESLint 10.

Resolution

  • Test app builds: WebdriverIO (9.31) always adds --import <tsx loader> to process.env.NODE_OPTIONS, and the enact pack processes spawned by build-apps.js inherit it.
    The tsx hook compiles required ES modules to CommonJS, so the import statements inside the ESM-only @eslint-react/eslint-plugin (loaded by eslint-config-enact) are resolved with require conditions and fail on packages with an import-only exports map. epack() now removes the tsx loader flag from NODE_OPTIONS for the spawned enact process;

  • Lint (dev only):

    • Updated eslint to ^10.11.0.
    • Removed the react/forbid-foreign-prop-types: 'off' override. The rule has no replacement in the ESLint 10 config and is no longer enabled.
    • screenshot/utils/confHelpers.js: the "Session health check failed" error now keeps the original error as cause (preserve-caught-error, new in ESLint 10's recommended rules).
    • screenshot/utils/redist/newFiles.js: removed the /* eslint-env browser */ comment, which flat config ignores and ESLint 10 reports as an error. document and window are already defined as globals by eslint-config-enact.
    • Solved newly surfaced eslint warnings/errors

Additional Considerations

Links

NXT-10859

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

@daniel-stoian-lgp daniel-stoian-lgp changed the title adapted for eslint 10 NXT-10859: Adapted code for eslint 10 Oct 5, 2026
@hong6316
hong6316 merged commit c5e4773 into develop Nov 2, 2026
0 of 2 checks passed
@hong6316
hong6316 deleted the feature/NXT-10859 branch November 2, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants