Skip to content

NXT-21335: Fixed WizardPanels remounting unmounted items - #468

Open
ion-andrusciac-lgp wants to merge 3 commits into
developfrom
feature/NXT-21335
Open

ion-andrusciac-lgp wants to merge 3 commits into
developfrom
feature/NXT-21335

Conversation

@ion-andrusciac-lgp

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Fixed WizardPanels remounting unmounted items

Resolution

useReverseTransition was using the usePrevious custom hook to determine the previous index during a transition. That hook introduced an extra re-render, and the logic inside useReverseTransition itself had also been changed.
The intended behavior was to return the previous index on the first render and the current index on the second render once the transition had completed, but it was always returning the current index.
Because of that, the component was invoking the wrong lifecycle methods on the unmounted views.

Additional Considerations

Links

NXT-21335

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.55%. Comparing base (d5fde95) to head (5fd9a67).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #468   +/-   ##
========================================
  Coverage    83.54%   83.55%           
========================================
  Files          158      158           
  Lines         7908     7911    +3     
  Branches      2446     2446           
========================================
+ Hits          6607     6610    +3     
  Misses        1011     1011           
  Partials       290      290           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant