Repository navigation
NXT-21335: Fixed WizardPanels remounting unmounted items - #468
Open
ion-andrusciac-lgp wants to merge 3 commits into
Open
ion-andrusciac-lgp wants to merge 3 commits into
ion-andrusciac-lgp wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #468 +/- ##
========================================
Coverage 83.54% 83.55%
========================================
Files 158 158
Lines 7908 7911 +3
Branches 2446 2446
========================================
+ Hits 6607 6610 +3
Misses 1011 1011
Partials 290 290 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…eature/NXT-21335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Fixed WizardPanels remounting unmounted items
Resolution
useReverseTransitionwas using theusePreviouscustom hook to determine the previous index during a transition. That hook introduced an extra re-render, and the logic insideuseReverseTransitionitself had also been changed.The intended behavior was to return the previous index on the first render and the current index on the second render once the transition had completed, but it was always returning the current index.
Because of that, the component was invoking the wrong lifecycle methods on the unmounted views.
Additional Considerations
Links
NXT-21335
Comments
Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com