docs: Approve the Release PR CI run instead of admin-merging - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @wagnercosta
🟢 Review tier: LOW — no human review needed
docs/runbooks/release.md(how to merge the release-please Release PR)git diff --checkclean, CI runs on this PRWhat
The runbook said GitHub never runs
pull_requestworkflows for the Release PR, so it can only be merged with an admin override. That is not what happens. GitHub creates the CI run and holds it for approval ("Action required", no jobs), which is why the required checks never report.The paragraph now says to approve that run (Approve and run workflows) and merge normally once both required checks pass. The admin merge stays as a fallback, with a note that it ships the release commit without CI.
Why
Verified on the 0.3.0 Release PR (#9): its CI run was approved, "Lint, typecheck, test, build" and "Node 24 compatibility" both passed, and the PR merged without an admin override. The CI runs for the 0.2.4 and 0.2.5 Release PRs have zero jobs: nobody approved them before those admin merges.
Risk / rollback
Docs only;
docs:does not trigger a release. Revert to restore the old paragraph.