Repository navigation
fix: onboard waits longer for the approval and tries an unreachable token endpoint again (1.7.2) - #175
Open
bitpshr wants to merge 1 commit into
Open
fix: onboard waits longer for the approval and tries an unreachable token endpoint again (1.7.2)#175bitpshr wants to merge 1 commit into
bitpshr wants to merge 1 commit into
Conversation
…oken endpoint again (1.7.2) - The sign-in waits 30 minutes instead of 5. Some people approve 10 to 30 minutes after the page opens, and those clicks reached nothing. - A token request that never connected is sent once more after 1 s; the code never got there, so it's still good. A request that connected is never sent again. When both tries fail to connect, the error page gets `temporarily_unavailable` instead of `server_error`. - A copied key that /v1/user refuses is "couldn't be checked", not "belongs to a different account": a key without user_read is refused there but works otherwise. The reason goes to the worker's log.
PaulAsjes
approved these changes
Oct 23, 2026
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in the focused reliability changes or regression coverage; tests were not executed during this review.
No open issues 🎉
What changed in this PR
This PR improves onboarding sign-in reliability and error reporting in the ElevenLabs CLI for version 1.7.2.
Changes:
- Extends onboarding approval waits to 30 minutes while leaving
auth loginat 5 minutes. - Retries token requests once after connection failures and distinguishes unreachable endpoints from other failures.
- Reports unverifiable clipboard keys separately from account mismatches and adds regression coverage.
| File | Description |
|---|---|
cli/elevenlabs/workflow/onboard/tests.rs |
Updates timeout expectations and tests key-verification outcomes. |
cli/elevenlabs/workflow/onboard/session.rs |
Extends the onboarding approval wait to 30 minutes. |
cli/elevenlabs/workflow/onboard/connect.rs |
Logs why clipboard-key verification failed. |
cli/elevenlabs/workflow/onboard/auth.rs |
Distinguishes unidentified accounts from confirmed account mismatches. |
cli/elevenlabs/workflow/loopback.rs |
Adds connection-failure retries, error classification, and regression tests. |
Cargo.toml |
Bumps the package version to 1.7.2. |
Cargo.lock |
Synchronizes the locked package version. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since 1.7.1, the Windows misses we fixed are mostly gone. Three
onboardproblems are left in the sign-in, on every OS. This fixes them:onboardnow waits 30 minutes.auth loginstill waits 5.server_errorwithout a grant, at the same rate in every country. Many take about 11 s, which is the 10 s connect timeout, and a retry in a new tab usually works. When the token request never connected, the code wasn't used, so the CLI now tries once more after 1 s. A request that did connect is never sent again. If both tries fail to connect, the error page getstemporarily_unavailableinstead ofserver_error, so these failures can be counted apart from the rest./v1/userrefused the copied key (401 or 403), onboard told the agent the key "belongs to a different account". A key withoutuser_readis refused there but works for everything else. It's nowcould_not_verify("the key couldn't be checked, so it wasn't stored"). "A different account" is kept for a key that does open another account.Bumps the version to 1.7.2.
Testing
cargo test: the workflow unit tests (194) and the onboard integration tests (26) pass on macOS. New or changed tests:server_errorafter 20 ms.windows-latestrunner with real Chrome and Edge, on this branch's code:server_error. With only a 400 ms outage, both signed in, because Windows itself keeps retrying a refused connect for about 2 s.A side effect of the longer wait: a sign-in nobody approves keeps its link and its port for up to 30 minutes. Running
onboard connectagain in that project shows the same link, as it did within the 5 minutes before.