Repository navigation
Fall back to in-memory settings when localStorage is blocked - #160
Open
Bortlesboat wants to merge 1 commit into
Open
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
Reading localStorage throws a SecurityError in a cross-origin iframe with third-party storage disabled, which crashed the app on load and left a blank page. Use a plain writable store in that case so the app still starts; settings just aren't remembered. Fixes ekzhang#152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sshx is embedded in a cross-origin iframe with third-party storage blocked, reading localStorage throws a SecurityError while the app loads and the page stays blank. This uses a plain writable store in that case, so the join screen renders and settings just aren't remembered. I checked it by bundling settings.ts and loading it with a localStorage that throws: it failed before the change and works after. svelte-check is clean.
Fixes #152