Repository navigation
gpubox: launch as fcvm-fleet-gpubox, which reads no secret; AMI builds are factory-only - #1979
Conversation
…s are factory-only gpubox.sh launched boxes with the fleet's host profile, which reads the fleet certificate and the agents' Access token. A gpubox needs neither: its agent unit starts only with the agent.env a fleet host's boot writes, and fcvm-fleet-vfio and fcvm-fleet-store use no secret. ejc3/aws (#922) narrows fcvm-fleet-terraform to gpubox's calls and adds the fcvm-fleet-gpubox profile. - fleet/tools/gpubox.sh: --iam-instance-profile Name=fcvm-fleet-gpubox, and the header says what the role and the box may do. - fleet/ami/README.md: the owner's 2026-11-21 decision. The image factory builds images. A dev box's role no longer launches builders, creates images or runs measure-boot.sh, and the hand build stays as the reference for the build.sh phases the factory runs. Tested: bash fleet/ami/check.sh (exit 0, shellcheck included); python3 -B fleet/tools/test_tools.py (OK).
☁️ Cloud World Model — Infrastructure Simulation ReportNo simulation was run and no credits were consumed. Link this installation, then re-run the check. Powered by Cloud World Model · Manage settings |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
NOT-A-DEFECT: CodeRabbit reports no actionable comments. Its merge note matches the plan: merge only after ejc3/aws#934 has created the |
|
I’m picking up the admission compatibility change identified in the AWS role review on this branch. I’ll add regression coverage for a missing ledger and a lock that disappears during contention. I’ll leave the profile migration and deployment sequencing with the current owners. |
Conditionally create an empty admission ledger after an ambiguous S3 403 and require a successful read before reserving capacity. Retry conditional lock acquisition once if a lock disappears before its read. Extend the fake S3 tests to cover restricted missing-key responses, a disappearing lock, and preservation of unreadable lock and ledger contents.
☁️ Cloud World Model — Infrastructure Simulation ReportNo simulation was run and no credits were consumed. Link this installation, then re-run the check. Powered by Cloud World Model · Manage settings |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
NOT-A-DEFECT: the 01:14 comment is a status note. The admission change it describes is 04b476f, which Codex reviewed with no findings. Cloud World Model ran no simulation (its app is not linked to a workspace). CodeRabbit's walkthrough reports no actionable comments. None of the three claims a defect. |
gpubox.shlaunched boxes with the fleet's host profile, which reads the fleet certificate and the agents' Access token. A gpubox needs neither:agent.envthat a fleet host's boot writes;fcvm-fleet-vfioandfcvm-fleet-storeuse no secret.ejc3/aws#934 narrows
fcvm-fleet-terraformto gpubox's calls (#922) and adds thefcvm-fleet-gpuboxprofile. The owner chose factory-only AMI builds on 2026-11-21.fleet/tools/gpubox.sh:--iam-instance-profile Name=fcvm-fleet-gpubox, and the header says what the role and the box may do.fleet/ami/README.md: records the decision. A dev box's role no longer launches builders, creates images or runsmeasure-boot.sh. The hand build stays as the reference for thebuild.shphases that the factory runs.Merge after ejc3/aws#934 is applied, because that apply creates the profile.
Contract: gpubox launches under a profile with no secret access.
Downstream impact: developer tooling only.
Evidence:
bash fleet/ami/check.shexits 0, including shellcheck, andpython3 -B fleet/tools/test_tools.pyis OK. Live check after the apply:up,run,copyanddown.Admission with restricted S3 permissions
The companion AWS role can read and write
gpubox/*objects but cannot list the bucket. S3 returns 403 for an absent ledger under that policy. The client now uses a conditional empty-object create to establish an absent ledger and requires a successful read afterward. When a lock disappears between a competing create and a read, the client retries its conditional acquisition once. It still refuses a launch if existing lock or ledger state cannot be read.Both regressions failed before the fix. All 51 operator-tool tests and the offline AMI checks passed on ARM, including the warning-level ShellCheck gate. A targeted test verified that an unreadable existing ledger or lock keeps its contents and no instance is launched. Deploy the AWS role first, then verify the normal GPU launch, commands, copy and termination against it.
Summary by CodeRabbit