Skip to content

Bootstrap the production TLS JSON before the coordinator starts - #941

Merged
ejc3 merged 1 commit into
mainfrom
fix/prod-tls-empty-bootstrap
Nov 21, 2026
Merged

ejc3 merged 1 commit into
mainfrom
fix/prod-tls-empty-bootstrap

Conversation

@ejc3

@ejc3 ejc3 commented Nov 21, 2026

Copy link
Copy Markdown
Owner

The production coordinator reads a JSON object from Secrets Manager on startup. A new TLS secret has no version, so this first read fails before the coordinator can issue its certificate. A live metadata-only check confirmed zero versions in the production container.

The Terraform creation hook inventories the secret, including versions without labels. It leaves an existing current version alone and reports ambiguous history for recovery. For a pristine secret it writes an empty JSON object with a stable version ID and a dedicated bootstrap label. AWS assigns AWSCURRENT to the first version. If a certificate wins the race, the seed receives only its own label. The ECS service depends on the creation hook. The bootstrap session can list versions and put a value on this secret, and never reads a certificate or key. AWS first-version and idempotency semantics

Seven new offline tests cover lost replies, retries, concurrent bootstrap and issuance, existing certificates, unlabeled history and service ordering. All 108 fleet, 19 fleet account, 12 production Cloudflare and two test-output checks passed. The ordering regression failed against main, and the concurrent writer test failed when the seed explicitly requested AWSCURRENT. CI runs the new suite.

…dinator

Add a create-time Terraform dependency and a scoped bootstrap which inventories the production secret's versions and writes only an empty JSON object under an explicit bootstrap label. Cover certificate preservation, interrupted and concurrent writes, and ECS ordering in CI.
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 816a3969-f1cc-4fba-bae5-8e8d90890b5f
Commits

Reviewing files that changed from the base of the PR and between e076b50 and a1e0f27.

Files selected for processing: 4

  • .github/workflows/lambda-tests.yml
  • fcvm-fleet-prod.tf
  • scripts/fcvm-prod-tls-seed.py
  • scripts/test-fcvm-prod-tls-seed.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T03:29:46.410781Z a1e0f27 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ejc3

ejc3 commented Nov 21, 2026

Copy link
Copy Markdown
Owner Author

@codex review
@coderabbitai review
@greptileai review

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: a1e0f27aad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ejc3
ejc3 merged commit 6dd37e7 into main Nov 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant