Repository navigation
Bootstrap the production TLS JSON before the coordinator starts - #941
Conversation
…dinator Add a create-time Terraform dependency and a scoped bootstrap which inventories the production secret's versions and writes only an empty JSON object under an explicit bootstrap label. Cover certificate preservation, interrupted and concurrent writes, and ECS ordering in CI.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
Action not completed
|
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The production coordinator reads a JSON object from Secrets Manager on startup. A new TLS secret has no version, so this first read fails before the coordinator can issue its certificate. A live metadata-only check confirmed zero versions in the production container.
The Terraform creation hook inventories the secret, including versions without labels. It leaves an existing current version alone and reports ambiguous history for recovery. For a pristine secret it writes an empty JSON object with a stable version ID and a dedicated bootstrap label. AWS assigns AWSCURRENT to the first version. If a certificate wins the race, the seed receives only its own label. The ECS service depends on the creation hook. The bootstrap session can list versions and put a value on this secret, and never reads a certificate or key. AWS first-version and idempotency semantics
Seven new offline tests cover lost replies, retries, concurrent bootstrap and issuance, existing certificates, unlabeled history and service ordering. All 108 fleet, 19 fleet account, 12 production Cloudflare and two test-output checks passed. The ordering regression failed against main, and the concurrent writer test failed when the seed explicitly requested AWSCURRENT. CI runs the new suite.