Skip to content

Fit the production NS delegation comment within Cloudflare’s 100-character limit - #940

Merged
ejc3 merged 1 commit into
mainfrom
fix/prod-delegation-comment-size
Nov 21, 2026
Merged

ejc3 merged 1 commit into
mainfrom
fix/prod-delegation-comment-size

Conversation

@ejc3

@ejc3 ejc3 commented Nov 21, 2026

Copy link
Copy Markdown
Owner

Cloudflare rejected both production NS delegation records for tiles.fcvm.dev with error 9313. Their shared comment was 113 characters and the zone accepts at most 100. The Terraform change shortens the comment to 75 characters while keeping the unsigned delegation documented.

The production DNS test failed on the original 113-character comment and passed with the fix. All 108 fleet tests, 12 production Cloudflare tests, and two test-output checks passed. Terraform formatting and diff checks passed. I measured the other production DNS comments after Terraform substitution at 82, 100, and 63 characters.

Keep the Cloudflare NS comment under the zone's 100-character limit and assert that limit in the production Terraform DNS test.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T03:25:24.894547Z 667206f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fc5eb8f1-82dc-4dea-b8b5-8dfbfd296328
Commits

Reviewing files that changed from the base of the PR and between e076b50 and 667206f.

Files selected for processing: 2

  • fcvm-fleet-prod-dns.tf
  • scripts/test-fcvm-fleet.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ejc3

ejc3 commented Nov 21, 2026

Copy link
Copy Markdown
Owner Author

@codex review
@coderabbitai review
@greptileai review

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 667206f30f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ejc3
ejc3 merged commit fbeac55 into main Nov 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant