Skip to content

fcvm-fleet: raise G Spot quota in us-east-1 to 480 vCPU for the prod stack (closes #913) - #937

Merged
ejc3 merged 1 commit into
mainfrom
fcvm-fleet-spot-g-480
Nov 21, 2026
Merged

ejc3 merged 1 commit into
mainfrom
fcvm-fleet-spot-g-480

Conversation

@ejc3

@ejc3 ejc3 commented Nov 21, 2026

Copy link
Copy Markdown
Owner

Closes #913. local.fcvm_fleet_spot_g_vcpus goes from 192 to 480 vCPU. Production's two awake g4dn.metal hosts already take all 192.

The 480 covers four users of the quota at once:

  • production's two hosts, 192;
  • the replacement a Spot interruption notice launches while the reclaimed host drains, 96;
  • staging's host, 96;
  • an image-factory build host, 96.

aws_servicequotas_service_quota.fcvm_fleet_spot_g_east1 already files max(local, current), so the apply requests 480 and never lowers the quota. AWS may take time to grant it.

Tested: python3 -S -B scripts/test-fcvm-fleet-account.py (OK) and terraform 1.10.3 fmt -check.

…stack (#913)

Production's two awake g4dn.metal hosts take 192 vCPU, which is the whole
current quota. A Spot interruption notice launches a replacement (96)
while the reclaimed host drains. Staging's host (96) and an image-factory
build host (96) share the region. Together that is 480. The resource
already files max(local, current), so the apply requests 480 and never
lowers it.

Tested: python3 -S -B scripts/test-fcvm-fleet-account.py (OK, with the test
renamed to 480); terraform 1.10.3 fmt -check.
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6be5f644-2607-4728-a5a6-a5c33ee858b0
Commits

Reviewing files that changed from the base of the PR and between 55474d1 and 8aaeaf5.

Files selected for processing: 2

  • fcvm-fleet-account.tf
  • scripts/test-fcvm-fleet-account.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T01:00:56.673644Z 8aaeaf5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ejc3

ejc3 commented Nov 21, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review
@greptileai review

Please review the us-east-1 G Spot quota change on 8aaeaf5. The standing quota request only changes the account ceiling.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ejc3
ejc3 merged commit 5e4790c into main Nov 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fcvm fleet: raise G Spot quota in us-east-1 to 480 vCPU for the prod stack

1 participant