Repository navigation
Validate the first production AMI seed under the Terraform lock - #933
Conversation
Defer release-version, regional availability and copy-lineage checks until Terraform is creating the protected production parameter. Preserve the current and rollback AMIs in both retention paths and serialize manual replication with the backend lock. Exercise stale saved plans and malformed retention pointers in the offline suites.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
@greptileai review |
|
@coderabbitai review |
|
@codex security review |
Action not completed
|
|
I reviewed the production seed and cleanup changes from
|
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Independent CLI code and security review of |
|
@codex review Please review dd5c5f7, especially the validated image and region inputs to the first-seed verifier. |
|
@codex security review |
Action not completed
|
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
) * fcvm fleet prod: lift the activation guard once #922 is done fcvm_fleet_prod_enabled refused true until staging and dev credentials could no longer change fcvm.dev DNS or present a certificate for a production name (#922). #929 deletes the two parent-zone tokens and revokes the staging certificates for fcvm.dev names; this removes the validation so the switch can be turned on. The default stays false: turning production on is its own change. Tested: python3 -S -B scripts/test-fcvm-dev-prod.py (OK); terraform 1.10.3 fmt -check. * fcvm fleet prod: turn production on fcvm_fleet_prod_enabled defaults to true. #922 is complete: both parent-zone DNS tokens are deleted at Cloudflare, the five staging certificates for fcvm.dev names are revoked and proven from signed CRLs, staging serves its subzone certificate over IPv4 and IPv6, and fcvm-arm's fleet role is gpubox-only. #930 lifted the guard. Every prod block is still gated on the switch, so turning production off again is this one line. The apply creates the prod stack (fcvm-dev-prod.tf, fcvm-fleet-prod*.tf). The prod AMI pointer is seeded from staging's current release, behind #933's apply-time check that its images exist. fcvm.dev's page stays unpublished until A6 (fcvm_fleet_prod_page_public). Tested: test-fcvm-dev-prod, -fleet, -fleet-prod-alarms, -coordinator-release, -dev and -tests-quiet pass (the two default assertions now say true); terraform 1.10.3 fmt -check and validate pass. * Pin why the prod guard can go: no token here writes fcvm.dev DNS Codex on #930 reviewed the branch's old base, where the two parent-zone DNS tokens and dev-server-role's read grant still existed. #936 removed them, and this branch now carries main. test-fcvm-dev-prod.py fails if any cloudflare_account_token or cloudflare_api_token names the fcvm.dev zone or holds DNS Write, so a token like that cannot come back while the guard is gone. Tested: the new test fails against the branch's old fcvm-dev.tf (with the tokens) and passes on this tree; test-fcvm-dev-prod and test-tests-quiet pass. * Keep the fleet activation guard until the staging budgets match Restore the input validation for all Terraform plans, update its error for the remaining billing check, and test both the guard and the retired DNS permission references. * Check retired DNS permissions in tokens with hyphenated labels --------- Co-authored-by: ejc3 <ejc3@users.noreply.github.com>
This addresses the AMI retention prerequisite in #922 and #930. The production activation guard and disabled default remain in place.
Changes
Verification