Deprecate Checkstyle report format, drop Checkstyle output formatter - #74
Merged
Merged
Conversation
ECS is a fixer by default, not a static analyzer. The Checkstyle report format targets CI static-analysis pipelines, so it is removed; requesting it now warns and falls back to the console format. The ext-dom suggest, needed only by the Checkstyle formatter, is dropped too.
nlemoine
added a commit
to timber/timber
that referenced
this pull request
Sep 15, 2026
ECS 13.3.0 removed its `checkstyle` output format (ecsphp/ecs-src#74), and `cs2pr` can only read that. Piping the console output into it failed with an XML parse error even when ECS reported no violations. A jq filter in `.github/scripts/` now builds the checkstyle report from the JSON one. It reports one warning per diff hunk, at the hunk's first changed line, where the old formatter gave one warning per file with no line at all. `cs2pr` keeps annotating the pull request and failing the job on violations, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69 and #71. ECS is a fixer by default, not a static analyzer. The
checkstylereport format targets CI static-analysis pipelines (GitHub Action reports) and has no place in a fixer-first tool.Removes:
CheckstyleOutputFormatterand its test + XML fixturecheckstyleentry in the collector testcheckstyleline and example from the README formatter listext-domsuggest, needed only by this formatterRequesting
--output-format=checkstylenow emits a warning and falls back toconsole, reusing theREMOVED_FORMATSmechanism from #69.Remaining formatters:
consoleandjson.