Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found in the expanded workflow. SummaryAdds Windows coverage to the existing JDK 17 Maven verification.
No actionable issues found. Maven verification was not run during this review. Reviews (1) · Last reviewed commit: "ci: run Maven verification on Windows as..." · Reviewed by Greptile |
Run the existing JDK 17 Maven verification job on both Ubuntu and Windows to catch platform-specific defects reported in eclipse-milo#2015. Signed-off-by: NUAAwqy <146524024+NUAAwqy@users.noreply.github.com>
NUAAwqy
force-pushed
the
taiyi/milo-2015-windows-maven-verify
branch
from
October 22, 2026 03:11
9f7ee53 to
779659e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2015 by running the existing
mvn -B verifyjob on bothubuntu-latestandwindows-latestwith JDK 17. The previous workflow only exercised Linux, so theWindows-only XML and filesystem regression described in the issue could pass CI
undetected.
Validation
.github/workflows/maven-verify.ymlwith PyYAML and asserted the two-runnermatrix, JDK 17 setup, checkout step, and unchanged Maven command.
git diff --checkpasses.execute the existing verification on both operating systems.
Prepared with Codex assistance; the change was checked against the repository's
workflow and contribution instructions.