Skip to content

ci: run Maven verification on Windows as well as Linux - #2133

Open
NUAAwqy wants to merge 2 commits into
eclipse-milo:mainfrom
NUAAwqy:taiyi/milo-2015-windows-maven-verify
Open

NUAAwqy wants to merge 2 commits into
eclipse-milo:mainfrom
NUAAwqy:taiyi/milo-2015-windows-maven-verify

Conversation

@NUAAwqy

@NUAAwqy NUAAwqy commented Oct 21, 2026

Copy link
Copy Markdown

Summary

Fixes #2015 by running the existing mvn -B verify job on both ubuntu-latest and
windows-latest with JDK 17. The previous workflow only exercised Linux, so the
Windows-only XML and filesystem regression described in the issue could pass CI
undetected.

Validation

  • Parsed .github/workflows/maven-verify.yml with PyYAML and asserted the two-runner
    matrix, JDK 17 setup, checkout step, and unchanged Maven command.
  • git diff --check passes.
  • The full Maven build was not run for this workflow-only change; GitHub Actions will
    execute the existing verification on both operating systems.

Prepared with Codex assistance; the change was checked against the repository's
workflow and contribution instructions.

@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found in the expanded workflow.

Summary

Adds Windows coverage to the existing JDK 17 Maven verification.

  • Maven verification runs on Linux and Windows.

No actionable issues found. Maven verification was not run during this review.

Reviews (1) · Last reviewed commit: "ci: run Maven verification on Windows as..." · Reviewed by Greptile

Run the existing JDK 17 Maven verification job on both Ubuntu and Windows to catch platform-specific defects reported in eclipse-milo#2015.

Signed-off-by: NUAAwqy <146524024+NUAAwqy@users.noreply.github.com>
@NUAAwqy
NUAAwqy force-pushed the taiyi/milo-2015-windows-maven-verify branch from 9f7ee53 to 779659e Compare October 22, 2026 03:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run the PR build on Windows as well as Linux

1 participant