Skip to content

fix(ci): skip the decision record branch rule on the release PR - #369

Merged
eFAILution merged 1 commit into
betafrom
fix/368-release-pr-decision-check
Oct 23, 2026
Merged

eFAILution merged 1 commit into
betafrom
fix/368-release-pr-decision-check

Conversation

@eFAILution

Copy link
Copy Markdown
Owner

Closes #368

The release PR (#357) adds every record that landed on beta, and its head is beta, so the branch rule always failed it. Each record already passed the rule on its own PR. Now the check skips the branch rule only for a same-repo beta -> main PR, and still validates the stores. A fork branch named beta still gets the rule.

  • npm run decisions:check passes
  • actionlint is clean
  • Unit tests pass (845)

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🛡️ Security Hardening Pipeline Results

Branch: fix/368-release-pr-decision-check
Commit: 1305128

Workflow Run: 618
Branch: fix/368-release-pr-decision-check
Commit: 1305128

Scan Status

Scanner Status
bandit ⏭️ skipped
checkov ⏭️ skipped
clamav ⏭️ skipped
codeql ✅ PASS
container ⏭️ skipped
dependency-review ✅ PASS
gitleaks ✅ PASS
grype ⏭️ skipped
lint ⏭️ skipped
opengrep ⏭️ skipped
osv ✅ PASS
sbom ⏭️ skipped
supply-chain ⏭️ skipped
trivy-container ⏭️ skipped
trivy-iac ⏭️ skipped
zap ⏭️ skipped

✅ All enabled scanners completed successfully.

Summaries Collected: 4

Scanner Results

🔬 CodeQL SAST (Javascript)

Status: Completed

Findings Summary

Critical High Medium Low Total
0 0 0 0 0

No security findings detected for Javascript.

Artifacts: CodeQL Reports (Javascript)

🔗 Dependency Review

Status: ✅ No issues found

No vulnerable or license-violating dependencies detected in this PR.
📋 View full report

🔑 Gitleaks (Secrets)

No 🔑 Gitleaks (Secrets) findings summary was produced.

📦 OSV (Dependencies)

No 📦 OSV (Dependencies) findings summary was produced.


Generated by Argus


Generated by Argus

The beta -> main release PR adds every record that landed on beta, and
its head branch has no issue number, so the check always failed it. Each
of those records already passed the rule on its own PR. Fork branches
named beta still get the rule.

Closes #368
@eFAILution
eFAILution force-pushed the fix/368-release-pr-decision-check branch from 2335f06 to 615e1d2 Compare October 23, 2026 13:32
@eFAILution
eFAILution merged commit 325a947 into beta Oct 23, 2026
24 checks passed
@eFAILution
eFAILution deleted the fix/368-release-pr-decision-check branch October 23, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant