Repository navigation
fix(notifications): approval requests reach the desk and phone (2.158.2) - #226
Merged
Merged
Conversation
Desk missed holds three ways: dedup on agent+title suppressed a second request on the same file once the first was read; unlocked rewrites of notifications.jsonl from several processes lost appended lines; the gateway refused rows from worktrees nested in a registered project. Dedup is now ref_id-scoped, rewrites take a file lock and replace atomically, and nested worktree rows are served. Full suite: 4988 passed, 8 skipped. Claude-Session: https://claude.ai/code/session_01RrQmyFoCnCy6eESz2Ume3d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C3 Desk missed some approval holds. Three causes: notification dedup keyed on agent+title suppressed a second request on the same file once the first was read; unlocked rewrites of
notifications.jsonlfrom several processes lost appended lines (old code lost 25-40 of 90 lines in the new concurrency test); and the gateway refused rows from worktrees nested in a registered project. Dedup is nowref_id-scoped, rewrites take a file lock and replace atomically, decision lines carry the request id, and nested-worktree rows are served by their project. Takes effect after the Oracle and Hub restart. Full suite: 4988 passed, 8 skipped.https://claude.ai/code/session_01RrQmyFoCnCy6eESz2Ume3d