Repository navigation
fix(mobile): session search and overview withhold transcript text (2.157.1) - #222
Merged
Merged
Conversation
…157.1) With mobile_sessions_transcripts off, ?q= still matched hidden prompts and first-prompt titles, and the overview's newest title carried no title_source, so a first-prompt title went out as is. Search now skips text the caller cannot see, and overview says where its title came from. Claude-Session: https://claude.ai/code/session_01HoyUtV4U8rmvyMqDPQdhxT
|
Gro could not finish this review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leaks in the v7 session routes from #221, found while building the phone's Sessions screen. Both apply only when
mobile_sessions_transcriptsis off, which is the default.GET /api/mobile/sessions?q=matched on prompts and first-prompt titles before they were blanked, so a search revealed which sessions contained a word.session_catalog._matchesandfilter_rows, pluslist_sessionsandlist_many, now taketranscripts=. It defaults to true, so the Hub behaves as before. With false, search sees only the id, branch, note, stale reason, and a title that did not come from the first prompt./api/mobile/sessions/overviewpassed a first-prompt title through asnewest.title, becausesession_catalog.overview()did not includetitle_source, so the withholding check never fired. The test mockedoverviewwith that field present, which hid the bug.newestnow carriestitle_source, and a new test runs the realoverview.Tests:
tests/test_mobile_fleet.py(+3), hub session routes and session catalog suites, 77 passed locally.https://claude.ai/code/session_01HoyUtV4U8rmvyMqDPQdhxT