Repository navigation
feat(hub): launch your agent, not a command named claude (2.149.0) - #202
Merged
Merged
Conversation
"Claude Code CLI" was hard-coded to the binary `claude`, so a box that starts its agent through a wrapper could only use the Custom slot, which was never stored. `ide_cmds` in hub_config.json and a per-project `ide_cmd` now override the command; launch-ide resolves custom_cmd, then the project's ide_cmd, then ide_cmds[ide], then the stock command. An override replaces the binary only, never the terminal-vs-GUI launch. Ported from uncommitted 2.142.0 work. Tests: test_hub_ide_cmd.py. Claude-Session: https://claude.ai/code/session_01F6QMHB2mkrDJiQWfC1g9wy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Claude Code CLI" was hard-coded to run
claude. If a machine starts its agent through a wrapper (yep, a project launcher), the only way in was the Custom slot, which was never saved, so the project card's launch button kept running the stock command.ide_cmdsin~/.c3/hub_config.jsonsets a command per IDE, for example{"claude-code": "yep"}. It can be edited from Hub Settings → Agent command.ide_cmdon a project (projects.json, set from Open in IDE) overrides the hub-wide value for that project, and the card's launch button uses it.POST /api/projects/launch-ideresolves in this order:custom_cmd, then the project'side_cmd, thenide_cmds[ide], then the stock command. An override replaces only the binary: a terminal CLI still opens in a terminal, and a GUI editor still gets the path.POST /api/projects/updateacceptside_cmd; a blank value clears it.This was uncommitted 2.142.0 work in the main checkout. That version number has since been taken, so it's ported onto current
mainas 2.149.0. The only conflicts were the version lines and two additions next to each other inhub_server.py, and both are kept.Tests:
tests/test_hub_ide_cmd.py; ruff clean. In the local full suite everything passed excepttest_codex_mcp_transport.py, which hangs onc3_session saveon this machine. It hangs the same way on unchangedmainand passed in #201's CI, so it's a local environment problem, not this change.https://claude.ai/code/session_01F6QMHB2mkrDJiQWfC1g9wy