Repository navigation
chore(release): 2.129.2 — the hub's override switch - #179
Merged
Merged
Conversation
Cuts a release for #178 so the feature can actually reach the box. The hub imports from site-packages, not the checkout (`~/.c3/hub_start.py` sets _REPO to the site-packages path), so a merge to main is invisible to the running process and a restart alone re-imports the same tree. Verified rather than assumed this time: GET /api/hub/overrides/policy on the live hub returned 405 — it fell through to the POST-only <request_id> route, which is exactly what "the route does not exist in this process" looks like. Both version sites bumped in one pass. test_version_sync exists because v2.56.0 shipped with pyproject.toml and cli/c3.py disagreeing, and it passes here — run AFTER the changelog edit, not before, since the last edit and the last verification have to be the same tree. 811 passed across the areas this release touches. The single failure, test_mobile_clients::test_chat_poll_shares_the_credential_set (404 != 401), is PRE-EXISTING test-ordering pollution: it passes in isolation and by file, and fails identically on clean main with the same -k. Proven before this branch existed, not asserted. Claude-Session: https://claude.ai/code/session_013z6ZciSk628VGRbLDZqB2n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts a release for #178 so the feature can actually reach the box.
Why a release is needed at all
The hub imports from site-packages, not the checkout —
~/.c3/hub_start.pysets
_REPOto the site-packages path — so a merge tomainis invisible tothe running process, and a restart alone re-imports the same tree.
Verified rather than assumed:
The 405 is the tell: it fell through to the POST-only
<request_id>route,which is exactly what "this route does not exist in this process" looks like.
c3 upgradeinstalls from PyPI, so it cannot see unreleasedmaineither.Path to live is merge → release → reinstall → restart → probe. This is step
two.
Contents
Only #178: the hub Access screen's "May agents ask?" panel,
GET/POST /api/hub/overrides/policy, and the extraction ofvalidation / widening / write into
services/override_policyso the hub andthe phone share one implementation.
Verification
test_version_syncexists becausev2.56.0 shipped with
pyproject.tomlandcli/c3.pydisagreeing — it passeshere, and it was run after the changelog edit, since the last edit and the
last verification have to be the same tree.
test_mobile_clients::TestClientAuth::test_chat_poll_shares_the_credential_set(
404 != 401), is pre-existing test-ordering pollution: it passes inisolation and by file, and fails identically on clean
mainwith the same-k. Proven before this branch existed, not asserted.After merge
Tag
v2.129.2, then watch the release run to green before any further pushto main. A push between the tag and the gate cancels the tagged CI run and the
release silently skips PyPI — that is what happened on v2.119.0. Then reinstall,
restart the hub, and probe
/api/hub/overrides/policyfor a 200.