Repository navigation
fix(network-ops): provision the full toolchain and harden the install script (ENG-8822) - #172
Merged
Merged
Conversation
… script (ENG-8822) On the local Docker sandbox the capability failed to load: install_coercion_tools.sh created root-owned system directories (/usr/share/wordlists, /opt) as the non-root sandbox user under `set -euo pipefail`, so the first failure aborted provisioning — and most of the toolchain was never declared for install at all. - Declare the apt tools (nmap, smbclient, hashcat, john) and pip tools (certipy-ad, bloodyAD) in dependencies; fetch NetExec's prebuilt binary in the install script (it is not on PyPI) and symlink `netexec` -> `nxc`. - Add a check for every invoked tool and fetched asset so a gap surfaces in pre-flight rather than as a command-not-found mid-run. - Route every privileged write through a sudo-aware (`sudo -n`), non-fatal helper so one unwritable path can no longer abort the capability load. - Add provisioning regression tests.
thomasqbrady
force-pushed
the
eng-8822-network-ops-toolchain
branch
from
October 14, 2026 14:13
63cf657 to
1cb478a
Compare
danielvaughn
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the local Docker sandbox, the
network-opscapability (2.1.7) failed to load. Two root causes:scripts/install_coercion_tools.shcreated root-owned system directories (/usr/share/wordlists,/opt) as the non-root sandbox user underset -euo pipefail, so the firstmkdirPermission-denied aborted the whole script and the capability failed to load.Changes
capability.yaml:nmap,smbclient,hashcat,johnimpacket,certipy-ad,bloodyADnxc) is not on PyPI, so the install script fetches its prebuilt standalone binary (pinnedv1.5.0, the most recent release carrying a Linux build) and symlinksnetexec/NetExec→nxc(the tools invokenetexec).checks:entry for every invoked tool and fetched asset, so a gap surfaces in pre-flight rather than as a command-not-found mid-run.sudo -n, non-fatal helper (ensure_writable_dir); downloads and clones are non-fatal. A sandbox without egress or sudo still loads the capability, just without the optional assets.tests/test_provisioning.py): static guards (toolchain declared, every tool checked, no unguarded privilegedmkdir, clones conditional) plus a behavioral test that runs the script with every privileged operation failing and asserts it still exits 0.Verification
dreadnode capability validatepasses (checks report the tools absent on the validation host, as expected — they install at provision time).netexecsymlink.network-opstest suite passes (54 tests).Note
This PR also lands the capability's in-progress 2.1.7 work (pipeline agents, skills, worker, tool updates) that was already staged in the working tree; the provisioning changes above are the focus.
ENG-8822